chore: migrate google-monitoring-dashboard to librarian#8679
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request enables automatic generation for the Google Monitoring Dashboard Node.js library by removing the skip_generate flag, deleting the owlbot configuration, updating repository metadata, and regenerating the entry point file. The feedback advises against manually editing the generated client configuration JSON files (.repo-metadata.json), noting that any metadata updates should be made upstream in the generator.
| "name": "monitoring", | ||
| "name_pretty": "Cloud Monitoring", |
There was a problem hiding this comment.
Do not manually edit generated client configuration JSON files. Any changes or updates to these metadata fields must be made upstream in the generator.
References
- Do not manually edit generated client configuration JSON files. Any changes or updates must be made upstream in the generator.
jskeet
force-pushed
the
scripted-migrate-google-monitoring-dashboard
branch
from
4614950 to
3ec3acb
Compare
danieljbruce
left a comment
danieljbruce
left a comment
There was a problem hiding this comment.
I think in alignment with #8650 we may want to remove some of the static files as well. The proposal shared with me was:
Add nothing:
Delete the following:
- packages/{xyz}/.OwlBot.yaml
- packages/{xyz}/.gitattributes
- packages/{xyz}/.prettierignore
- packages/{xyz}/.prettierrc.js
- packages/{xyz}/CONTRIBUTING.md
- packages/{xyz}/CODE_OF_CONDUCT.md
- packages/{xyz}/LICENSE
- packages/{xyz}/samples/generated/{api version}/snippet_metadata*.json
Modify the following: - .repo-metadata.json
- librarian.yaml
That said, there seems to be nothing wrong with merging this PR. It is the minimum required to migrate which is nice. We just may want to remove other files as a follow-up task.
|
@danieljbruce Those files to delete either are deleted, or already don't exist before this PR :) |
2 participants
No description provided.