feat(Spanner): Add the built in metrics feature#9055
Open
Hectorhammett wants to merge 11 commits intomainfrom
Open
feat(Spanner): Add the built in metrics feature#9055Hectorhammett wants to merge 11 commits intomainfrom
Hectorhammett wants to merge 11 commits intomainfrom
Conversation
Hectorhammett
force-pushed
the
builtin-metrics
branch
from
e2592f7 to
122f5fa
Compare
Hectorhammett
added
the
do not merge
shylene40
approved these changes
Apr 13, 2026
There was a problem hiding this comment.
"global" location is only a fallback , if customer application is not deployed on GCP. We need to detect Client location , if not available then fall back to GCP
There was a problem hiding this comment.
instance_id can not be blank as it is a monitored resource. If for some reason (should not be happening) the instance_id is not available use a default value like 'unknown' , else customer would see error
There was a problem hiding this comment.
We should not be hardcoding the status to "OK" . We should wait for RPC completion and record the actual status. This is what has been done for other languages
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds the Client built in metrics for Spanner.
b/406082122