feat(auth): Add blocking Regional Access Boundary Lookup and Seed Support#16720
Open
macastelaz wants to merge 16 commits intogoogleapis:mainfrom
Open
feat(auth): Add blocking Regional Access Boundary Lookup and Seed Support#16720macastelaz wants to merge 16 commits intogoogleapis:mainfrom
macastelaz wants to merge 16 commits intogoogleapis:mainfrom
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request renames the "Trust Boundary" feature to "Regional Access Boundary" (RAB) and introduces a centralized management system for it. Key changes include the implementation of _RegionalAccessBoundaryManager for thread-safe state handling and background refreshes, and the update of multiple credential types to support this new mechanism. The with_trust_boundary method is deprecated in favor of with_regional_access_boundary. Review feedback recommends updating a type hint in the utility module to correctly reflect the expected data types and removing redundant error logging in the base credentials class to reduce log noise.
macastelaz
force-pushed
the
clean-rab-gcloud
branch
from
0785de5 to
23ad64b
Compare
…undary implementation
Renamed 'with_regional_access_boundary' to '_with_regional_access_boundary' to indicate internal use.
Update the comment block of "_with_regional_access_boundary" to inform future maintainers of the necessity to maintain a backwards compatible contract of this method.
macastelaz
force-pushed
the
clean-rab-gcloud
branch
from
7686ffb to
78bd7e6
Compare
macastelaz
force-pushed
the
clean-rab-gcloud
branch
from
8c0bcee to
81a2d2c
Compare
macastelaz
force-pushed
the
clean-rab-gcloud
branch
from
03803f7 to
87880a6
Compare
macastelaz
force-pushed
the
clean-rab-gcloud
branch
from
4bd1c9c to
1872dd1
Compare
macastelaz
changed the title
nbayati
reviewed
Apr 24, 2026
Contributor
nbayati
left a comment
nbayati
left a comment
There was a problem hiding this comment.
Overall looks really good! Just a few small comments and questions.
- Add test for token refresh and RAB lookup sequencing in before_request. - Add failure test to verify blocking RAB lookups are not retried. - Restore and refine test for skipping RAB lookup when URL is None. - Fix swapped url/method arguments in before_request test calls. - Document why OAuth2 credentials skip independent RAB lookups. - Internalize blocking lookup method with leading underscore.
nbayati
reviewed
Apr 24, 2026
ohmayr
added
the
do not merge
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In order for the gcloud CLI to support Regional Access Boundary, the Python auth SDK needs to support blocking lookups as well as allowing an initial seed RAB to be provided (gcloud will set this seed if the CLI has a locally cached valid RAB available).
Additional details can be found at go/rab-python-gcloud-one-pager