Skip to content

chore: remove name_pretty_override from librarian.yaml#16812

Closed
jskeet wants to merge 9 commits intogoogleapis:mainfrom
jskeet:remove-name-pretty-override-2
Closed

chore: remove name_pretty_override from librarian.yaml#16812
jskeet wants to merge 9 commits intogoogleapis:mainfrom
jskeet:remove-name-pretty-override-2

Conversation

@jskeet
Copy link
Copy Markdown
Contributor

@jskeet jskeet commented Apr 27, 2026

This isn't needed for handwritten libraries, and generated libraries should have values taken from sdk.yaml

Towards googleapis/librarian#5463

@jskeet jskeet requested a review from parthea April 27, 2026 09:46
@jskeet jskeet requested review from a team as code owners April 27, 2026 09:46
@jskeet jskeet requested review from tswast and removed request for a team April 27, 2026 09:46
Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request implements a large-scale update to product naming conventions across numerous client libraries, primarily by removing "Google" and "Google Cloud" prefixes from product names in metadata and documentation files. These changes are reflected in librarian configurations, repository metadata, and README files to ensure a more concise branding. I have no feedback to provide.

@jskeet jskeet force-pushed the remove-name-pretty-override-2 branch from 59fd8f8 to 59c3269 Compare April 27, 2026 14:00
@parthea
Copy link
Copy Markdown
Contributor

parthea commented Apr 27, 2026

@ohmayr Please could you check the reason that django-spanner-django5.2-tests / system-tests ran in this PR?

Do we need to add dorny/paths-filter@v3 similar to this config in bigtable

check_changes:
runs-on: ubuntu-latest
outputs:
run_bigtable: ${{ steps.filter.outputs.bigtable }}
steps:
- uses: actions/checkout@v4
- uses: dorny/paths-filter@v3
id: filter
with:
filters: |

https://github.com/googleapis/google-cloud-python/blob/main/.github/workflows/django-spanner-django5.2_tests.yml

parthea added a commit that referenced this pull request Apr 27, 2026
As of #16624,
`django-google-spanner` presubmits are being triggered on every PR,
regardless of whether `django-google-spanner` was changed. We should
only trigger presubmit tests when there are changes to
`django-google-spanner` or the action itself.

See
#16812 (comment)
@jskeet
Copy link
Copy Markdown
Contributor Author

jskeet commented Apr 28, 2026

Closing this PR so we can get everything else in first.

@jskeet jskeet closed this Apr 28, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants