fix: avoid retaining routing parameter instances in cache - #17961
Merged
parthea merged 2 commits intoAug 4, 2026
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request replaces the use of @functools.cache with @utils.cached_property on RoutingParameter methods in wrappers.py to prevent memory leaks caused by instances being retained in the cache. A unit test has been added to verify that RoutingParameter instances can be garbage collected properly. There are no review comments, and I have no additional feedback to provide.
parthea
approved these changes
Jul 31, 2026
parthea
added
kokoro:force-run
yoshi-kokoro
removed
kokoro:run
parthea
requested changes
Jul 31, 2026
daniel-sanche
approved these changes
Aug 3, 2026
mingi3314
force-pushed
the
fix/routing-parameter-instance-cache
branch
from
August 4, 2026 00:17
dbc181c to
353ace6
Compare
parthea
added
kokoro:force-run
yoshi-kokoro
removed
kokoro:run
parthea
approved these changes
Aug 4, 2026
Contributor
|
Thanks @mingi3314! |
parthea
enabled auto-merge (squash)
August 4, 2026 17:27
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
functools.cache keeps method arguments, including self, in its unbounded cache. As a result, RoutingParameter instances remain alive after routing resolution.
Use the existing instance-scoped utils.cached_property for the compiled regex and routing key while preserving the to_regex() method API. Add a regression test that verifies a populated cache does not retain the instance.
Testing: