fix(bigframes): fix field name typos for ai.generate* functions - #17983
Open
sycai wants to merge 2 commits into
Open
fix(bigframes): fix field name typos for ai.generate* functions#17983sycai wants to merge 2 commits into
sycai wants to merge 2 commits into
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request fixes a typo in several AI operations where "full_resposne" was corrected to "full_response", and adds corresponding integration tests to verify accessing the "full_response" field using the legacy Ibis compiler. The feedback suggests wrapping the yield statement in the use_ibis_compiler fixture within a try...finally block to ensure that the global SQL compiler setting is properly restored even if a test fails.
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
sycai
marked this pull request as ready for review
August 3, 2026 21:01
sycai
requested review from
GarrettWu and
tswast
and removed request for
a team
August 3, 2026 21:01
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #17708 🦕