Skip to content

test(compute-v1): Address flaky tests #34623

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
aandreassa wants to merge 1 commit into
base: main
Choose a base branch
from
+4 −3
Draft

test(compute-v1): Address flaky tests #34623

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions google-cloud-compute-v1/acceptance/google/cloud/compute/v1/pagination_smoke_test.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,6 @@
require "minitest/autorun"

# Trigger PR build to check quota failures
require "google/cloud/errors"
require "google/cloud/compute/v1/accelerator_types"

Expand Down Expand Up @@ -56,7 +57,7 @@ def test_filter

def test_aggregated_list_each
zone_at_pairs = []
@client.aggregated_list(project: @default_project, max_results:10).each do |zone, at_grouped_list|
@client.aggregated_list(project: @default_project, max_results: 100).each do |zone, at_grouped_list|
at_grouped_list.accelerator_types.each { |at| zone_at_pairs << [zone, at.name] }
end

Expand All @@ -65,7 +66,7 @@ def test_aggregated_list_each

def test_aggregated_list_each_page
zone_at_pairs = []
@client.aggregated_list(project: @default_project, max_results:10).each_page do |page|
@client.aggregated_list(project: @default_project, max_results: 100).each_page do |page|
page.each do |zone_grouped_list|
zone = zone_grouped_list[0]
at_grouped_list = zone_grouped_list[1]
Expand Down
2 changes: 1 addition & 1 deletion google-cloud-compute-v1/samples/quickstart.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -188,7 +188,7 @@ def delete_instance project:, zone:, instance_name:
# @param [Numeric] timeout seconds until timeout (default is 3 minutes)
# @return [::Gapic::GenericLRO::Operation] Finished Operation object.
def wait_until_done operation:, timeout: 3 * 60
retry_policy = ::Gapic::Operation::RetryPolicy.new initial_delay: 0.2, multiplier: 2, max_delay: 1, timeout: timeout
retry_policy = ::Gapic::Operation::RetryPolicy.new initial_delay: 5.0, multiplier: 2.0, max_delay: 15.0, timeout: timeout
operation.wait_until_done! retry_policy: retry_policy
end
# [END compute_instances_operation_check]
Loading