feat: recycle channel on consecutive new stream failures#2903
feat: recycle channel on consecutive new stream failures#2903
Conversation
product-auto-label
Bot
added
size: m
| } else if (!status.isOk() && status.getCode() != Code.CANCELLED) { | ||
| channelWrapper.consecutiveFailures++; | ||
| } | ||
| releaseChannel(channelWrapper, status); |
There was a problem hiding this comment.
Not related to this PR, but I feel releaseChannel should be called releaseStream or something, with recycleChannel the naming gets a little confusing..
There was a problem hiding this comment.
I guess the meaning here was that a session is closing and releasing the channel it was using.
| } | ||
|
|
||
| private static boolean shouldRecycleChannel(Status status) { | ||
| private static boolean shouldRecycleChannel(ChannelWrapper channelWrapper, Status status) { |
There was a problem hiding this comment.
Also unrelated to this PR.. I'm wondering how this works..
if we get unimplemented, shouldn't the client fallback to unary? (iiuc which doesn't use this channel pool) recycling the channel and try to create a new one likely still won't work?
There was a problem hiding this comment.
Yes, we will eventually fallback to unary if recycling doesn't help. But I've added a backoff not to spam new connections rapidly and indefinitely.
| private static final String DEFAULT_LOG_NAME = "pool"; | ||
| private static final AtomicInteger INDEX = new AtomicInteger(); | ||
|
|
||
| private static final int CONSECUTIVE_OPEN_FAILURE_THRESHOLD = 5; |
There was a problem hiding this comment.
wondering if this should be called CONSECUTIVE_OPEN_SESSION_FAILURE_THRESHOLD.
And I think this should come from client config?
There was a problem hiding this comment.
Renamed and added a todo.
3 participants
Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:
Fixes #<issue_number_goes_here> ☕️
If you write sample code, please follow the samples format.