fix: Fix vulerability by using query parameters instead of string formatting - #159
Open
dishaprakash wants to merge 8 commits into
Open
fix: Fix vulerability by using query parameters instead of string formatting#159dishaprakash wants to merge 8 commits into
dishaprakash wants to merge 8 commits into
Conversation
product-auto-label
Bot
added
the
api: cloudsql-mysql
divyang-dalal
approved these changes
Jul 24, 2026
loeng2023
approved these changes
Jul 28, 2026
loeng2023
reviewed
Jul 28, 2026
|
|
||
| [[tool.mypy.overrides]] | ||
| module="google.auth.*" | ||
| module = [ |
Contributor
There was a problem hiding this comment.
Since this PR changes import modules of mypy, I guess some change to .github/workflows/lint.yml is needed, you can manually run mypy to see what went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR patches critical SQL injection vulnerabilities within the vector store implementations. Previously, various methods constructed SQL statements using raw Python string interpolation. This PR restructures these queries to use proper parameterized execution bindings
Similar to googleapis/llama-index-alloydb-pg-python#233