fix: Remove Begin transaction on non retryable error#2168
Draft
surbhigarg92 wants to merge 22 commits intogoogleapis:mainfrom
Draft
fix: Remove Begin transaction on non retryable error#2168surbhigarg92 wants to merge 22 commits intogoogleapis:mainfrom
surbhigarg92 wants to merge 22 commits intogoogleapis:mainfrom
Conversation
product-auto-label
bot
added
size: l
surbhigarg92
force-pushed
the
begin_on_non_retryable_error
branch
from
ed10ef2 to
e1c3097
Compare
product-auto-label
bot
added
size: m
surbhigarg92
force-pushed
the
begin_on_non_retryable_error
branch
from
e1c3097 to
65acc23
Compare
odeke-em
reviewed
Oct 23, 2024
Comment on lines
746
to
775
| .on('error', err => { | ||
| const isServiceError = | ||
| err && typeof err === 'object' && 'code' in err; | ||
| if ( | ||
| !this.id && | ||
| this._useInRunner && | ||
| !( | ||
| isServiceError && | ||
| (err as grpc.ServiceError).code === grpc.status.ABORTED | ||
| ) | ||
| ) { | ||
| this.begin(); | ||
| } | ||
| setSpanError(span, err); | ||
| }) |
Contributor
There was a problem hiding this comment.
I don't believe that the right fix is to delete this code but rather to check that the error is retryable by checking if these grpc error codes are returned:
- DEADLINE_EXCEEDED
- UNAVAILABLE
- INTERNAL
although I guess the next step is to ask after this.begin() what happens next?
Extracted out of PR googleapis#2158, this change traces Database.runTransactionAsync. Updates googleapis#2079
surbhigarg92
force-pushed
the
begin_on_non_retryable_error
branch
from
d48d83b to
f321749
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.