-
Notifications
You must be signed in to change notification settings - Fork 112
chore: replace old nodejs teams with cloud-sdk-nodejs-team #2522
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Warning: This pull request is touching the following templated files:
|
Summary of ChangesHello @suztomo, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request updates the code ownership configuration for the Highlights
Changelog
Activity
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request updates the .github/CODEOWNERS file to replace an old Node.js team with a new one. The change is correct, but I've left a comment with a couple of minor suggestions to update a related code comment and to add a standard newline at the end of the file.
|
|
||
| # Unless specified, the jsteam is the default owner for nodejs repositories. | ||
| * @googleapis/spanner-client-libraries-nodejs @googleapis/jsteam No newline at end of file | ||
| * @googleapis/spanner-client-libraries-nodejs @googleapis/cloud-sdk-nodejs-team No newline at end of file |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A couple of minor suggestions:
- The comment on line 8 is now stale and should be updated to refer to
@googleapis/cloud-sdk-nodejs-team. - This file should end with a newline character, which is a standard convention. I've added it in the suggestion below.
* @googleapis/spanner-client-libraries-nodejs @googleapis/cloud-sdk-nodejs-team
414396c to
497b992
Compare
b/479541676