chore: remove build badges #4027
Conversation
Summary of ChangesHello @suztomo, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request focuses on tidying up the project documentation by eliminating references to old and potentially irrelevant build status badges. The change ensures that the README files present accurate and current information, contributing to better maintainability and clarity for developers. Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request removes old build badge references from several README files. The changes are generally correct, but I've found one issue. In hermetic_build/library_generation/tests/resources/test-owlbot/testdata/README-golden.md, the link definition for [javadocs] is removed along with the badge links, which will break the 'Client Library Documentation' link. This should be preserved. Additionally, to prevent these badges from being added back in the future, the source template at hermetic_build/library_generation/owlbot/templates/java_library/README.md should also be updated to remove the 'CI Status' section.
I am having trouble creating individual review comments. Click here to see my feedback.
hermetic_build/library_generation/tests/resources/test-owlbot/testdata/README-golden.md (168-178)
The [javadocs] link definition on line 168 is being removed along with the badge links. However, this link is used on line 9 for the 'Client Library Documentation'. Please restore this line to avoid a broken link.
b/468377909
suztomo
force-pushed
the
chore-remove-badges
branch
from
2d8b4ad to
9199e8d
Compare
|
|
|
All checks passed. |
1 participant
Removes old badge references.
In the monorepo generation test, I had to disable the README comparison check with google-cloud-java, because google-cloud-java hasn't received the updates from this change yet.
b/468377909