feat!: migrate android-maps-ktx into android-maps-utils (v6.0.0) #1716
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,3 +1,3 @@ | ||
| { | ||
| ".": "6.0.0-rc04" | ||
| } | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,149 @@ | ||
| /* | ||
| * Copyright 2026 Google LLC | ||
| * | ||
| * Licensed under the Apache License, Version 2.0 (the "License"); | ||
| * you may not use this file except in compliance with the License. | ||
| * You may obtain a copy of the License at | ||
| * | ||
| * http://www.apache.org/licenses/LICENSE-2.0 | ||
| * | ||
| * Unless required by applicable law or agreed to in writing, software | ||
| * distributed under the License is distributed on an "AS IS" BASIS, | ||
| * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
| * See the License for the specific language governing permissions and | ||
| * limitations under the License. | ||
| * | ||
| */ | ||
|
|
||
| package com.google.maps.android.clustering | ||
|
|
||
| import com.google.maps.android.clustering.Cluster | ||
| import com.google.maps.android.clustering.ClusterItem | ||
| import com.google.maps.android.clustering.ClusterManager | ||
| import kotlinx.coroutines.channels.awaitClose | ||
| import kotlinx.coroutines.flow.Flow | ||
| import kotlinx.coroutines.flow.callbackFlow | ||
|
|
||
| /** | ||
| * Returns a flow that emits when a cluster is clicked. Using this to observe cluster clicks | ||
| * will override an existing listener (if any) to [ClusterManager.setOnClusterClickListener]. | ||
| * | ||
| * **Warning**: This is a cold flow wrapping a single-listener SDK callback. Concurrently subscribing | ||
| * multiple collectors will result in listener hijacking, and cancelling any observer will unregister | ||
| * the active listener completely. Always share this flow (e.g. using [kotlinx.coroutines.flow.shareIn]) | ||
| * for multi-observer configurations. | ||
| * | ||
| * **Note on event consumption**: The underlying SDK listener returns the result of `trySend().isSuccess`. | ||
| * When an emission is accepted by the flow buffer, the click event is considered consumed (`true`), | ||
| * suppressing default SDK behavior (such as zooming). Under backpressure if the buffer is full, | ||
| * `trySend` returns `false`, allowing default SDK click handling to proceed. | ||
| */ | ||
| public fun <T : ClusterItem> ClusterManager<T>.clusterClickEvents(): Flow<Cluster<T>> = | ||
|
Collaborator
There was a problem hiding this comment. These six functions are public and return So the published POM for Can you move it to |
||
| callbackFlow { | ||
| setOnClusterClickListener { | ||
| trySend(it).isSuccess | ||
|
dkhawk marked this conversation as resolved.
|
||
| } | ||
| awaitClose { | ||
| setOnClusterClickListener(null) | ||
| } | ||
| } | ||
|
|
||
| /** | ||
| * Returns a flow that emits when a cluster item is clicked. Using this to observe cluster item clicks | ||
| * will override an existing listener (if any) to [ClusterManager.setOnClusterItemClickListener]. | ||
| * | ||
| * **Warning**: This is a cold flow wrapping a single-listener SDK callback. Concurrently subscribing | ||
| * multiple collectors will result in listener hijacking, and cancelling any observer will unregister | ||
| * the active listener completely. Always share this flow (e.g. using [kotlinx.coroutines.flow.shareIn]) | ||
| * for multi-observer configurations. | ||
| * | ||
| * **Note on event consumption**: The underlying SDK listener returns the result of `trySend().isSuccess`. | ||
| * When an emission is accepted by the flow buffer, the click event is considered consumed (`true`), | ||
| * suppressing default SDK behavior. Under backpressure if the buffer is full, `trySend` returns `false`, | ||
| * allowing default SDK click handling to proceed. | ||
| */ | ||
| public fun <T : ClusterItem> ClusterManager<T>.clusterItemClickEvents(): Flow<T> = | ||
| callbackFlow { | ||
| setOnClusterItemClickListener { | ||
| trySend(it).isSuccess | ||
| } | ||
| awaitClose { | ||
| setOnClusterItemClickListener(null) | ||
| } | ||
| } | ||
|
|
||
| /** | ||
| * Returns a flow that emits when a cluster's info window is clicked. Using this to observe cluster info window clicks | ||
| * will override an existing listener (if any) to [ClusterManager.setOnClusterInfoWindowClickListener]. | ||
| * | ||
| * **Warning**: This is a cold flow wrapping a single-listener SDK callback. Concurrently subscribing | ||
| * multiple collectors will result in listener hijacking, and cancelling any observer will unregister | ||
| * the active listener completely. Always share this flow (e.g. using [kotlinx.coroutines.flow.shareIn]) | ||
| * for multi-observer configurations. | ||
| */ | ||
| public fun <T : ClusterItem> ClusterManager<T>.clusterInfoWindowClickEvents(): Flow<Cluster<T>> = | ||
| callbackFlow { | ||
| setOnClusterInfoWindowClickListener { | ||
| trySend(it).isSuccess | ||
| } | ||
| awaitClose { | ||
| setOnClusterInfoWindowClickListener(null) | ||
| } | ||
| } | ||
|
|
||
| /** | ||
| * Returns a flow that emits when a cluster's info window is long clicked. Using this to observe cluster info window long clicks | ||
| * will override an existing listener (if any) to [ClusterManager.setOnClusterInfoWindowLongClickListener]. | ||
| * | ||
| * **Warning**: This is a cold flow wrapping a single-listener SDK callback. Concurrently subscribing | ||
| * multiple collectors will result in listener hijacking, and cancelling any observer will unregister | ||
| * the active listener completely. Always share this flow (e.g. using [kotlinx.coroutines.flow.shareIn]) | ||
| * for multi-observer configurations. | ||
| */ | ||
| public fun <T : ClusterItem> ClusterManager<T>.clusterInfoWindowLongClickEvents(): Flow<Cluster<T>> = | ||
| callbackFlow { | ||
| setOnClusterInfoWindowLongClickListener { | ||
| trySend(it).isSuccess | ||
| } | ||
| awaitClose { | ||
| setOnClusterInfoWindowLongClickListener(null) | ||
| } | ||
| } | ||
|
|
||
| /** | ||
| * Returns a flow that emits when a cluster item's info window is clicked. Using this to observe cluster item info window clicks | ||
| * will override an existing listener (if any) to [ClusterManager.setOnClusterItemInfoWindowClickListener]. | ||
| * | ||
| * **Warning**: This is a cold flow wrapping a single-listener SDK callback. Concurrently subscribing | ||
| * multiple collectors will result in listener hijacking, and cancelling any observer will unregister | ||
| * the active listener completely. Always share this flow (e.g. using [kotlinx.coroutines.flow.shareIn]) | ||
| * for multi-observer configurations. | ||
| */ | ||
| public fun <T : ClusterItem> ClusterManager<T>.clusterItemInfoWindowClickEvents(): Flow<T> = | ||
| callbackFlow { | ||
| setOnClusterItemInfoWindowClickListener { | ||
| trySend(it).isSuccess | ||
| } | ||
| awaitClose { | ||
| setOnClusterItemInfoWindowClickListener(null) | ||
| } | ||
| } | ||
|
|
||
| /** | ||
| * Returns a flow that emits when a cluster item's info window is long clicked. Using this to observe cluster item info window long clicks | ||
| * will override an existing listener (if any) to [ClusterManager.setOnClusterItemInfoWindowLongClickListener]. | ||
| * | ||
| * **Warning**: This is a cold flow wrapping a single-listener SDK callback. Concurrently subscribing | ||
| * multiple collectors will result in listener hijacking, and cancelling any observer will unregister | ||
| * the active listener completely. Always share this flow (e.g. using [kotlinx.coroutines.flow.shareIn]) | ||
| * for multi-observer configurations. | ||
| */ | ||
| public fun <T : ClusterItem> ClusterManager<T>.clusterItemInfoWindowLongClickEvents(): Flow<T> = | ||
| callbackFlow { | ||
| setOnClusterItemInfoWindowLongClickListener { | ||
| trySend(it).isSuccess | ||
| } | ||
| awaitClose { | ||
| setOnClusterItemInfoWindowLongClickListener(null) | ||
| } | ||
| } | ||
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
AGENTS.md says not to hand edit this or CHANGELOG.md. The title is already
feat!:so release-please lands on 6.0.0 by itself. Can we revert both and let it do its job?Also worth checking: the description says final 6.0.0, but
release-please-config.jsonis untouched and still has"prerelease": truewith"prerelease-type": "rc". As it stands the next run gives us 6.0.0-rc05, not 6.0.0.