Skip to content

fix(executor): follow drive#operation downloadUri for large Shared-Drive downloads #907

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
TheSecMaven wants to merge 1 commit into
base: main
Choose a base branch
from
+454 −4
Open

fix(executor): follow drive#operation downloadUri for large Shared-Drive downloads #907

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 16 additions & 0 deletions .changeset/fix-drive-download-follows-operation-uri.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,16 @@
---
"@googleworkspace/cli": patch
---

Fix `drive.files.download` not writing the file for large Shared-Drive downloads.

For a large binary file living in a Shared Drive, Drive can respond to a download
request with a `drive#operation` JSON envelope naming a `downloadUri` to fetch the
actual bytes from, instead of returning the bytes directly. The response handler had
no branch for this shape: it fell into the ordinary JSON-response path, printed the
envelope itself as if it were the command's output, and never wrote the requested
`--output` file at all — silently, with no error.

The download-response envelope is now recognized (`kind: "drive#operation"` carrying
a `downloadUri`/`downloadUrl`) and its URI is followed with a second request before
the file is written, restricted to Google's own API/storage/user-content hosts.
Loading
Loading