Skip to content

Four configuration seams that run.go never feeds #101

Description

@SirLouen

Current state: authkit.Config.SessionTTL, ratelimit.Config, server.Config.MaxStreamLifetime and server.Config.MaxStreamsPerUser all exist as configuration fields and run.go sets none of them, so every install takes the library default of thirty day sessions, ten failed logins a minute per client IP, five minute streams and five concurrent streams per user. None can be changed without a rebuild.

Proposal: read all four in loadRunConfig and assign them, following the pattern ALPHONE_TENANT_MACHINE_GRACE already sets, with today's values as defaults.

Trigger: each answers to an environment variable, and an install setting none behaves exactly as it does today.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    deferredIssues that have been found during a feat dev and were deferred for later

    Type

    No type

    Fields

    Priority

    None yet

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions