cl: featQuietIgnore, InlineFuncIgnore; tool: cfg.IgnoreInline - #888
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #888 +/- ##
==========================================
+ Coverage 87.60% 87.64% +0.04%
==========================================
Files 22 22
Lines 1944 1951 +7
==========================================
+ Hits 1703 1710 +7
Misses 241 241
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Review summary
Clean, well-scoped refactor that splits the single featIgnored flag into featExplicitIgnore / featQuietIgnore (= featAllIgnore) and adds an IgnoreInline config so inline-function skips can be logged quietly. The two-flag model is applied consistently: featAllIgnore is the uniform "should I bail?" test, and the quiet/explicit distinction is only consulted when deciding whether to log (ignoref) or when recording a type's ignore reason. Logic and format strings are sound — no security or performance concerns (the pipeline is fully sequential, so the mutable global is not a data race today).
The main design concern is the public, mutable package-level var cl.InlineFuncIgnore, which carries two latent correctness issues (not reset across runs; sub-package IgnoreInline not honored). Details inline. A few terminology/comment nits also noted.
No description provided.