Skip to content

cl: conf.FailFast; isParameterPack; ctx.nsFeats/getTypeObj; varHasInitExpr - #892

Merged
xushiwei merged 3 commits into
goplus:mainfrom
xushiwei:q
Oct 2, 2026
Merged

xushiwei merged 3 commits into
goplus:mainfrom
xushiwei:q

Conversation

@xushiwei

@xushiwei xushiwei commented Oct 2, 2026 •

Copy link
Copy Markdown
Member

No description provided.

@xushiwei xushiwei changed the title cl: conf.FailFast; isParameterPack; ctx.nsFeats/getTypeObj; varHasIni… cl: conf.FailFast; isParameterPack; ctx.nsFeats/getTypeObj; varHasInitExpr Oct 2, 2026
@codecov

codecov Bot commented Oct 2, 2026 •

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 79.03226% with 13 lines in your changes missing coverage. Please review.
✅ Project coverage is 87.64%. Comparing base (98eed07) to head (f82e839).
⚠️ Report is 37 commits behind head on main.

Files with missing lines Patch % Lines
cl/var.go 55.55% 4 Missing ⚠️
cl/ctx.go 83.33% 3 Missing ⚠️
cl/type.go 60.00% 2 Missing ⚠️
cl/typedef.go 75.00% 2 Missing ⚠️
cl/class.go 93.75% 1 Missing ⚠️
cl/func.go 50.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #892      +/-   ##
==========================================
- Coverage   87.66%   87.64%   -0.03%     
==========================================
  Files          23       23              
  Lines        1970     1991      +21     
==========================================
+ Hits         1727     1745      +18     
- Misses        243      246       +3     
Flag Coverage Δ
llgo-tests 87.64% <79.03%> (-0.03%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@fennoai fennoai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review summary

This PR introduces fail-fast error handling (FailFast), a TypeAlias config, parameter-pack detection for templates, and consolidates ignore/type-lookup logic (getTypeObj, nsFeats, ignoreType). The renames (isConfTypeIgnored, getTypeObj) and the consolidated Type_Record/Typedef/Enum handling in toTypeEx are clear improvements.

One correctness bug stands out: ignoreType merges feats into a value copy that is never written back to the map, so re-ignoring an already-registered local type is a silent no-op. Remaining items are robustness and doc-accuracy nits. Details inline.

Comment thread cl/ctx.go
Comment thread cl/ctx.go
Comment thread cl/var.go
Comment thread cmd/llcppg/gen.go
Comment thread cl/compile.go
Comment thread cl/typedef.go Outdated
@xushiwei
xushiwei merged commit c865232 into goplus:main Oct 2, 2026
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant