cl: conf.FailFast; isParameterPack; ctx.nsFeats/getTypeObj; varHasInitExpr - #892
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #892 +/- ##
==========================================
- Coverage 87.66% 87.64% -0.03%
==========================================
Files 23 23
Lines 1970 1991 +21
==========================================
+ Hits 1727 1745 +18
- Misses 243 246 +3
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Review summary
This PR introduces fail-fast error handling (FailFast), a TypeAlias config, parameter-pack detection for templates, and consolidates ignore/type-lookup logic (getTypeObj, nsFeats, ignoreType). The renames (isConfTypeIgnored, getTypeObj) and the consolidated Type_Record/Typedef/Enum handling in toTypeEx are clear improvements.
One correctness bug stands out: ignoreType merges feats into a value copy that is never written back to the map, so re-ignoring an already-registered local type is a silent no-op. Remaining items are robustness and doc-accuracy nits. Details inline.
No description provided.