Skip to content

Upgrade install-vulkan-sdk to @v1.1.2#26

Draft
MarshallW906 wants to merge 6 commits intomainfrom
ci-upgrade-legacy-actions
Draft

Upgrade install-vulkan-sdk to @v1.1.2#26
MarshallW906 wants to merge 6 commits intomainfrom
ci-upgrade-legacy-actions

Conversation

@MarshallW906
Copy link
Copy Markdown
Collaborator

This will resolve #19

@MarshallW906 MarshallW906 self-assigned this Jan 9, 2024
@MarshallW906 MarshallW906 linked an issue Jan 9, 2024 that may be closed by this pull request
@MarshallW906 MarshallW906 marked this pull request as draft January 9, 2024 12:56
@MarshallW906
Copy link
Copy Markdown
Collaborator Author

Okay I believe alexkiri/install-vulkan-sdk WILL work but it has NOT been published into Github Actions Marketplace

Need something else

@shurunxuan
Copy link
Copy Markdown
Collaborator

You are using 1.1.2 but from their repo it seems it's 1.1.1.

@MarshallW906
Copy link
Copy Markdown
Collaborator Author

That's not the case. :(

The one available on marketplace is 1.1.1, which uses the legacy cache@v2.
There's a fork, alexkiri/install-vulkan-sdk, which uses modern actions/cache saying its version be 1.1.2, but not published.

@MarshallW906
Copy link
Copy Markdown
Collaborator Author

Is it Okay to use vulkan 1.3.250.1? Tried using another action but the way it constructs download link on Linux is correct only until 1.3.250.1

@MarshallW906
Copy link
Copy Markdown
Collaborator Author

Otherwise we fork one of the existing actions and create one on our own

@MarshallW906
Copy link
Copy Markdown
Collaborator Author

No never mind, this one even fails on mac

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Warning Elimination: Some workflow steps are deprecated

2 participants