Conversation
|
Duplicate from #39 |
|
@vincentchalamon, I agree with the objective. The difference with #39 is that this PR does not imply major version change (no BC break), just fix a CI failure. #39 will imply a major version bump. I just want to be able to merge #38 without @magarzon to suffer a build failure. |
|
Removing PHP5 from the CI is not a BC break. I would better just remove PHP5 from the CI, but not from the composer.json |
|
Nope, but #39 will require a php version >= 7.x (in composer.json), hence requiring a major version bump IMO
That’s the point. I want to tag a minor release version compatible with php5.6 and allowing symfony 5 Then, I want to tag a new major version requiring a more recent php version, dropping all unsupported php version.tests. |
vincentchalamon
left a comment
There was a problem hiding this comment.
That’s the point. I want to tag a minor release version compatible with php5.6 and allowing symfony 5
OK I see. So LGTM!
Then, I want to tag a new major version requiring a more recent php version, dropping all unsupported php version.tests.
It's not only about bumping the php version from the composer.json file, I think it would require some code improvement to PHP7.
|
thanks :) |
Travis’ builds are failing on php5, blocking some useful PR.
Allowing them to fail.