feat(log): migrate to github.com/gotd/log abstraction#1770
Merged
Conversation
Replace go.uber.org/zap (*zap.Logger) with the github.com/gotd/log Logger/Helper interface across all production code, tests, cmd binaries, and examples. Callers that need zap for test observability wrap via logzap.New(); the gotd/log/logzap replace directive is wired in go.mod. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Drop local replace directives now that both modules are published. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1770 +/- ##
==========================================
- Coverage 71.20% 71.07% -0.14%
==========================================
Files 500 501 +1
Lines 23476 23500 +24
==========================================
- Hits 16717 16703 -14
- Misses 5535 5570 +35
- Partials 1224 1227 +3 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
go.uber.org/zap(*zap.Logger) with thegithub.com/gotd/logLogger/Helperinterface across all production code, test support files, cmd binaries, and examplesgithub.com/gotd/log/logzapas a direct dependency; wirereplacedirectives ingo.modandexamples/go.modlogzap.New(zaptest.NewLogger(t)); no-op helpers uselog.For(log.Nop)Fix #128
Test plan
go build ./...passes (main module and examples module)go test ./...passes with no failuresgo.uber.org/zapimports remain in production (non-test) files🤖 Generated with Claude Code