Ensure conditions match question type#2867
Open
thomasiles wants to merge 6 commits into
Open
Conversation
When a question is changed to selection type which supports routing from multiple options, we need to make sure the conditions are updated to match. This commit adds a new method which is called when a question is changed. It updates conditions to based on the selection options for the new question.
When the answer type for a question with conditions is changed, we show a banner warning the user that the routes will be deleted. When changing the answer type in a form with multiple branches, we do not want to show this banner as the conditions are not being deleted. This commit hides the banner when the answer type is changed in a form with multiple branches.
lfdebrux
reviewed
Jun 26, 2026
Co-authored-by: Laurence de Bruxelles <laurence.debruxelles@digital.cabinet-office.gov.uk>
thomasiles
force-pushed
the
ensure_conditions_match_question_type_tmp
branch
from
dc24632 to
688e10d
Compare
|
🎉 A review copy of this PR has been deployed! You can reach it at: https://pr-2867.admin.review.forms.service.gov.uk/ It may take 5 minutes or so for the application to be fully deployed and working. If it still isn't ready For the sign in details and more information, see the review apps wiki page. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Make conditions match the question type, if changed
Trello card: https://trello.com/c/lDyxaMH5/3145-if-a-question-with-an-unconditional-route-is-changed-to-a-select-one-list-question-set-all-the-options-to-go-to-the-same-target
When a question is changed to selection type which supports routing from multiple options, we need to make sure the conditions are updated to match.
This commit adds a new method which is called when a question is changed. It updates conditions to based on the selection options for the new question.
Things to consider when reviewing