Update warnings when deleting route questions#2868
Open
SamJamCul wants to merge 1 commit into
Open
Conversation
f72a8aa to
feaf95d
Compare
feaf95d to
3c42b89
Compare
|
🎉 A review copy of this PR has been deployed! You can reach it at: https://pr-2868.admin.review.forms.service.gov.uk/ It may take 5 minutes or so for the application to be fully deployed and working. If it still isn't ready For the sign in details and more information, see the review apps wiki page. |
Contributor
|
Content looks grand and all the right messages show for the right situations. yay thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What problem does this pull request solve?
https://trello.com/c/NL0r23hr/3142-update-warnings-when-deleting-a-question-at-the-start-or-end-of-a-route-if-multiple-branches-is-enabled
The warning notification when deleting a page will reflect the routing situation around the page - if there are one or more routes to or from the page, the banner will describe this accordingly.
Things to consider when reviewing