Skip to content

Update warnings when deleting route questions#2868

Open
SamJamCul wants to merge 1 commit into
mainfrom
update-warnings-when-deleting-a-question-at-the-start-or-end-of-a-route
Open

Update warnings when deleting route questions#2868
SamJamCul wants to merge 1 commit into
mainfrom
update-warnings-when-deleting-a-question-at-the-start-or-end-of-a-route

Conversation

@SamJamCul

Copy link
Copy Markdown
Contributor

What problem does this pull request solve?

https://trello.com/c/NL0r23hr/3142-update-warnings-when-deleting-a-question-at-the-start-or-end-of-a-route-if-multiple-branches-is-enabled

The warning notification when deleting a page will reflect the routing situation around the page - if there are one or more routes to or from the page, the banner will describe this accordingly.

image

Things to consider when reviewing

  • Ensure that you consider the wider context.
  • Does it work when run on your machine?
  • Is it clear what the code is doing?
  • Do the commit messages explain why the changes were made?
  • Are there all the unit tests needed?
  • Do the end to end tests need updating before these changes will pass?
  • Has all relevant documentation been updated?

@SamJamCul SamJamCul force-pushed the update-warnings-when-deleting-a-question-at-the-start-or-end-of-a-route branch from f72a8aa to feaf95d Compare June 26, 2026 08:57
@SamJamCul SamJamCul force-pushed the update-warnings-when-deleting-a-question-at-the-start-or-end-of-a-route branch from feaf95d to 3c42b89 Compare June 26, 2026 09:16
@github-actions

Copy link
Copy Markdown

🎉 A review copy of this PR has been deployed! You can reach it at: https://pr-2868.admin.review.forms.service.gov.uk/

It may take 5 minutes or so for the application to be fully deployed and working. If it still isn't ready
after 5 minutes, there may be something wrong with the ECS task. You will need to go to the integration AWS account
to debug, or otherwise ask an infrastructure person.

For the sign in details and more information, see the review apps wiki page.

@hannahkc

Copy link
Copy Markdown
Contributor

Content looks grand and all the right messages show for the right situations. yay thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants