SPIKE: Add support for uploading a spreadsheet containing Welsh translations#2870
Draft
stephencdaly wants to merge 3 commits into
Draft
SPIKE: Add support for uploading a spreadsheet containing Welsh translations#2870stephencdaly wants to merge 3 commits into
stephencdaly wants to merge 3 commits into
Conversation
stephencdaly
force-pushed
the
spike-support-translations-upload
branch
2 times, most recently
from
8700acf to
1d4052a
Compare
Allow uploading a CSV file in the same format as the existing CSV download for the form content. Add an identifier to each CSV row so we can identify which translation to update. When the CSV is uploaded, show the add/edit translations page with the translations filled from the CSV file. The translations will not be saved until the user submits this page. This code was mainly generated by Claude code for the purpose of spiking this, so might not all be the best way to do it.
stephencdaly
force-pushed
the
spike-support-translations-upload
branch
from
1d4052a to
9c19c37
Compare
stephencdaly
changed the title
stephencdaly
force-pushed
the
spike-support-translations-upload
branch
from
e77865e to
81c5e2d
Compare
stephencdaly
force-pushed
the
spike-support-translations-upload
branch
from
81c5e2d to
a91b4ed
Compare
|
🎉 A review copy of this PR has been deployed! You can reach it at: https://pr-2870.admin.review.forms.service.gov.uk/ It may take 5 minutes or so for the application to be fully deployed and working. If it still isn't ready For the sign in details and more information, see the review apps wiki page. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What problem does this pull request solve?
Trello card: https://trello.com/c/EBUuaK6P/3161-spike-make-it-easier-to-add-welsh-translations-to-a-long-list-of-options
Allow uploading a spreadsheet file (CSV, XLSX, or ODS) in the same format as the existing CSV download for the form content.
Add an identifier to each CSV row so we can identify which translation to update.
When the spreadsheet is uploaded, show the add/edit translations page with the translations filled from the spreadsheet. The translations will not be saved until the user submits this page.
Some of the code for this was generated by Claude code for the purpose of spiking this, so might not all be the best way to do it. When implementing it properly, make sure to properly review all the decisions made in this PR.
This hasn't been properly designed, but for a proof of concept this adds a link to a page to upload a CSV with the translations:
Not yet investigated
Things to consider when reviewing