Update banner notifications when changing a select-one question with routes from answers#2879
Open
SamJamCul wants to merge 2 commits into
Open
Conversation
When changing the answer type of a selection question, we only need to delete conditions associated with that question if it was a single selection question. If it could have multiple options, then we don't need to remove existing conditions.
|
🎉 A review copy of this PR has been deployed! You can reach it at: https://pr-2879.admin.review.forms.service.gov.uk/ It may take 5 minutes or so for the application to be fully deployed and working. If it still isn't ready For the sign in details and more information, see the review apps wiki page. |
lfdebrux
changed the title
lfdebrux
approved these changes
Jul 1, 2026
Contributor
|
Checked content (plural and singular) and it looks good! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What problem does this pull request solve?
Trello card: https://trello.com/c/P4dayADV/3143-update-banner-notifications-when-changing-a-select-one-question-with-routes-from-answers
Updates the banner that shows when changing the answer type from a selection question, with only one option. The banner no longer shows if it's a selection question with multiple options.
The banner says
routeorroutesdepending on the number of routes from that question.Things to consider when reviewing