Add exit pages#2880
Open
thomasiles wants to merge 9 commits into
Open
Conversation
Add a new table, exit_pages, for the new ExitPage model. ExitPages are always linked to a page and are deleted when the page is deleted.
Add a model and factory for exit pages. We also add basic validations to make sure the exit page has a heading and markdown body. No character limits have been set yet.
Page gets a new association for exit pages. Each page can have multiple exit pages.
To support Welsh, ExitPages now have a translations table. The heading and markdown attributes will have translations, matching the current use of Conditions.
Add an optional association from Condition to ExitPage.
Change the exit_page? method on Conditions to check for an associated ExitPage as a fallback to using exit_page_markdown. This is to support the transition from the old exit_page_markdown column to the new ExitPage model.
Exit pages will appear in the form document. Because exit pages are tied to a question page, and a page can have multiple exit pages, we add an array to Step in the form document.
If the answer type or number of selection options changes, delete any existing ExitPages as well as any conditions associated with them. We combine the conditions to make the code neater and wrap all the database interactions in a transaction. This means they either all get commited or none of them do.
|
🎉 A review copy of this PR has been deployed! You can reach it at: https://pr-2880.admin.review.forms.service.gov.uk/ It may take 5 minutes or so for the application to be fully deployed and working. If it still isn't ready For the sign in details and more information, see the review apps wiki page. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add new ExitPage table and model
Trello card: https://trello.com/c/E1qseSQu/3163-add-model-for-exit-pages-to-forms-admin?filter=member%3Atomiles3
This PR adds a new model for ExitPages. The model isn't used anywhere yet. The
"exit_pages": []entry will appear in formdocument's steps.Things to consider when reviewing