fix: reset fragmentation state on seek to prevent invalid fragment ranges#548
Open
fix: reset fragmentation state on seek to prevent invalid fragment ranges#548
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
After upgrading this library from
0.5.6to the current version2.3.0, I was intermittently seeing errors whereISOFile.createFragment()was called with an invalid sample range (sampleEnd < sampleStart), especially around seek operations.Root cause:
seek()updatedtrak.nextSample, but per-track fragmentation/extraction state was not reset.So after a seek, state could be out of sync (for example, stale
lastFragmentSampleNumberfrom before seek vs newnextSampleafter seek).This could cause:
sampleEnd < sampleStart) after backward seeksSolution
On each track seek (
seekTrack), reset seek-sensitive per-track state:lastFragmentSampleNumbertonextSamplelastSegmentSampleNumbertonextSampleaccumulatedSizeto0segmentStreamAlso added a defensive guard in
createFragment:sampleEnd < sampleStart, skip fragment creation safely and warn