Repository navigation
Probe the session lock with a shared lock on a read-only channel - #30
Merged
Merged
Conversation
The probe opened the producer's lock read-write. An agent running as another user usually has no write access to it, so the open failed, the state was UNKNOWN, and the session never completed. - Open the lock read-only and try a shared lock. It still conflicts with the writer's exclusive lock (fcntl on POSIX, LockFileEx on Windows), so ACTIVE and UNOWNED mean what they did. - When the lock cannot be opened, log one warning per session directory naming the permissions the agent's user needs. - Add a README section on running the agent as a separate user.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The agent decides that a producer finished by probing its
.gpufl-session.lock. The probe opened the lock read-write. An agent running as another user (for example the systemd usergpufl-agent) usually has no write access to it, so the open failed, the state was UNKNOWN, and the session never completed. An H100 run neededchmod g+rwon every lock after each run.Pairs with gpu-flight/gpufl-client#177, which creates the lock group-readable (0660 masked by the umask). Each change is safe without the other: with an older client the agent still cannot open the lock and now says so.
Testing
./gradlew checkpasses: 176 tests, 1 skipped (a POSIX-only test on this Windows host), coverage gate passed.