Repository navigation
Let launcher-started agents upload the serving channel - #182
Closed
CodingInAVan wants to merge 1 commit into
Closed
CodingInAVan wants to merge 1 commit into
CodingInAVan wants to merge 1 commit into
Conversation
The Python serving writer records LLM-serving data in its own session directories, in a channel named serving. The agent's own default now tails it, but gpufl trace --upload and gpufl upload always pass the agent an explicit list of four channels, so those sessions were never uploaded by an agent the launcher started. Add serving to both lists. A channel with no windows is a no-op for the agent.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The Python serving writer (gpu-flight/gpufl-serving) records LLM-serving data in its own session directories, in a channel named
serving.gpufl trace --uploadandgpufl uploadalways pass the agent they start an explicit list of four channels (device,scope,system,sass), so an agent started by the launcher would never upload those sessions. Both lists now includeserving, and the--log-typeshelp text says so.A channel with no windows is a no-op for the agent; an older agent that does not know the channel simply finds nothing. Native capture is unchanged. The agent side is gpu-flight/gpufl-agent#31.
Type of Change
Testing
gpufl_testswith the launcher suites: 152 tests pass, including the updated default inCliParseTrace.UploadFlag.Checklist