Repository navigation
Prepare gpufl client 1.3.0rc7 - #187
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bumps the version to 1.3.0rc7. This commit touches only
CMakeLists.txtGPUFL_VERSION_SUFFIX,pyproject.tomlandpython/gpufl/__init__.py.release.ymlrewrites only the numeric CMake version from the tag, so the suffix has to be committed.rc7 contains:
gpufl trace --stacks=on|offand report the stack choice.#186 and the backend. rc7 changes no backend upload until the NVIDIA toolkit image's client pin moves. On gpufl-backend
dev:gpufl tracewithout--upload. Its Dockerfile says only the separate contained uploader invokes Java, and the application has no upload path.GPUFL_LOG_TYPES=device,scope,system,sass(DockerArtifactUploader.java:191,GpuArtifactUploader.java:84,AgentUploader.java:62). They don't go through the launcher, so Let the agent choose the channels it uploads #186 doesn't reach them.gpufl trace --upload, but it builds gpufl-client atv1.3.0rc6(.github/workflows/deploy-experiment.yml:88). Once that pin moves,gpufl trace --uploadthere uploads every channel the agent finds unless it passes--log-types. An exportedGPUFL_LOG_TYPESno longer narrows it.To release: merge with "Create a merge commit", then tag that merge commit
v1.3.0rc7. The tag publishes to PyPI and the Jupyter image.Next: a gpufl-backend PR pins the AMD runtime image (
experiment/amd-runtime/Dockerfile, today80137e35from #183) to rc7 for the dev qualification indocs/amd-pc-sampling-plan.md.