fix: migrations yarn 1 install and eslint config issues#2503
Merged
Conversation
Contributor
Contributor
There was a problem hiding this comment.
Pull request overview
Updates create-plugin’s dependency installation behavior so Yarn Classic (v1) doesn’t fail migrations/updates when package engines constraints don’t match the user’s environment.
Changes:
- Add
--ignore-enginesto the Yarn v1 “silent install” command used during migrations/updates.
hugohaggmark
approved these changes
Mar 2, 2026
github-project-automation
bot
moved this from 📬 Triage
to 🔬 In review
in Grafana Catalog Team
jackw
changed the title
github-project-automation
bot
moved this from 🔬 In review
to 🚀 Shipped
in Grafana Catalog Team
Contributor
|
🚀 PR was released in |
grafana-plugins-platform-bot
bot
added
the
released
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
If migrations or additions make changes to dependencies in the plugin the runner will then attempt to install the new packages. However this fails with yarn 1 due to not setting the --ignore-engines flag. This PR adds the flag so subsequent migrations can run without being interrupted.
The PR also fixes an issue where references to configs from plugins were not being written out correctly resulting in broken JS.
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
📦 Published PR as canary version:
Canary Versions✨ Test out this PR locally via:
npm install @grafana/create-plugin@7.0.1-canary.2503.22583707467.0 npm install @grafana/plugin-docs-cli@0.0.5-canary.2503.22583707467.0 # or yarn add @grafana/create-plugin@7.0.1-canary.2503.22583707467.0 yarn add @grafana/plugin-docs-cli@0.0.5-canary.2503.22583707467.0