fix(create-plugin): unpin @playwright/test now that 1.62.1 fixes tsconfig resolution - #2815
Merged
Conversation
tolzhabayev
marked this pull request as ready for review
August 3, 2026 11:29
tolzhabayev
requested review from
eledobleefe,
jackw and
joshhunt
and removed request for
a team
August 3, 2026 11:29
grafana-catalog-project-bot
Bot
moved this from 📬 Triage
to 🔬 In review
in Grafana Catalog Team
leventebalogh
approved these changes
Aug 4, 2026
github-project-automation
Bot
moved this from 🔬 In review
to 🚀 Shipped
in Grafana Catalog Team
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Playwright 1.62.1 shipped with the fix for the tsconfig
extendsregression (microsoft/playwright#41989), so scaffolded plugins extending@grafana/tsconfigload fine again. Verified locally with a minimal scaffold layout:playwright test --liston 1.62.1 resolves the config where 1.62.0 crashed.This reverts the
~1.61.1template pin from #2806 back to a caret range (^1.62.1, so the broken 1.62.0 can never be resolved) and removes the temporary playwright pin step from ci.yml.Which issue(s) this PR fixes:
Fixes #2805
Special notes for your reviewer: