fix: address Copilot PR #12 review suggestions#13
Merged
Conversation
- ci.yml: add workflow-level RUNNING_LOCALLY env var; gate upload-artifact on env.RUNNING_LOCALLY == '' so it only runs on real GitHub Actions (not locally via act), eliminating the need for continue-on-error: true - ci-cd-test-run.ps1: pass --env RUNNING_LOCALLY=true to all act invocations (dry-run and full execution) so the upload step is skipped locally - ci-cd-test-run.ps1: add explicit push-to-master event payload (-e flag) to Release workflow in full-execution path, matching the dry-run path - ci-cd-test-run.ps1: narrow dry-run error filter — remove broad 'The system cannot find the file specified' exclusion from both $failed and $knownArtifactCacheIssue; use only the specific .cache\act\actions-upload-artifact pattern to detect the known act Windows cache-cleanup bug
There was a problem hiding this comment.
Pull request overview
This PR updates the local CI runner and CI workflow to incorporate the 3 review-thread fixes from PR #12, improving correctness of local act runs and making artifact upload failures fatal on real GitHub Actions runs.
Changes:
- Add a workflow-level
RUNNING_LOCALLYenv var and gate the CI artifact upload step so it’s skipped underactbut enforced on GitHub Actions. - Update
ci-cd-test-run.ps1to always passRUNNING_LOCALLY=truetoact(dry-run + full run). - Ensure the Release workflow is not skipped in full execution by supplying an explicit push-to-master event payload, and tighten the dry-run failure filter to avoid masking unrelated errors.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
ci-cd-test-run.ps1 |
Passes RUNNING_LOCALLY=true to act, adds Release event payload in full runs, and narrows the dry-run error filter; cleans up temp event files. |
.github/workflows/ci.yml |
Defines RUNNING_LOCALLY and makes upload-artifact conditional so local runs skip it while real CI treats failures as fatal. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Addresses the 3 Copilot review threads on PR #12.\n\n## Changes\n\n###
ci.yml— Thread 1: conditional upload step\n\n- Added a workflow-levelRUNNING_LOCALLY: \"\"env variable (defined in the workflow so actionlint accepts it)\n- Changedupload-artifactstep fromcontinue-on-error: truetoif: always() && env.RUNNING_LOCALLY == ''\n- On real GitHub ActionsRUNNING_LOCALLYis empty → step runs and failures are fatal\n- Locally viaact(whereci-cd-test-run.ps1passes--env RUNNING_LOCALLY=true) → step is skipped entirely\n- Removes the false-negative risk where a genuine upload failure on real CI would be silently swallowed\n\n###ci-cd-test-run.ps1— Thread 2: Release event payload in full-execution path\n\n- Added the same explicit push-to-master event payload (-e) to the Release workflow in the full-execution path (Step 4)\n- Dry-run (Step 3) already supplied this payload; the full-execution path did not, so the Release workflow could be skipped silently\n- Temp event file is cleaned up in thefinallyblock, matching the dry-run pattern\n\n###ci-cd-test-run.ps1— Thread 3: narrowed dry-run error filter\n\n- Removed the broad'The system cannot find the file specified'exclusion from both$failedand$knownArtifactCacheIssue\n- That message can come from unrelated failures and was masking real errors\n- Now uses only the specific\\.cache\\\\act\\\\actions-upload-artifactpath pattern, which precisely targets the known act Windows cache-cleanup bug\n\n## Validation\n\n-actionlint: zero violations on bothci.ymlandrelease.yml\n- Dry-run: CI and Release workflows both pass locally viaact -n"