Repository navigation
Restrict product XLSX import to the global admin scope - #889
Merged
Merged
Conversation
KrzysztofPajak
force-pushed
the
fix/product-import-tenant-scope
branch
2 times, most recently
from
October 10, 2026 08:16
271afb2 to
4b925a4
Compare
Matches the rule brands, categories and collections already follow.
KrzysztofPajak
force-pushed
the
fix/product-import-tenant-scope
branch
from
October 10, 2026 08:17
4b925a4 to
f7d2353
Compare
KrzysztofPajak
changed the title
![github-code-quality[bot]](https://avatars.githubusercontent.com/u/9919?s=60&v=4){kind=small}
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Type: bugfix
Issue
The product XLSX import in
BaseProductControllerwas not limited to the global admin scope, unlike the brand, category and collection imports.Solution
ImportExcelnow rejects the import when the product data scope is store or vendor scoped. The user gets the access-denied message and is redirected to the list. The import manager is not called. This is the same rule the brand, category and collection imports follow.Breaking changes
None. The main admin panel imports as before. The Store and Vendor panels do not offer product import in their UI.
Testing
dotnet test src/Tests/Grand.Web.Admin.Tests --filter "FullyQualifiedName~BaseProductControllerTests". The newImportExcel_StoreScope_*andImportExcel_VendorScope_*tests pass, and so do the existing import tests.