Skip to content

fix: allow redirect on successful payment #2583

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Giovanni-Schroevers wants to merge 2 commits into
base: canary
Choose a base branch
from
Open

fix: allow redirect on successful payment #2583

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
01bb1df
fix: allow redirect on successful payment
Giovanni-Schroevers Jan 21, 2026
369a102
Merge remote-tracking branch 'origin/canary' into fix/msp-unable-to-p…
Giovanni-Schroevers Jan 21, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/sunny-hoops-attend.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
'@graphcommerce/magento-payment-multisafepay': patch
---

Fixed a bug in MSPPaymentHandler where successful MultiSafepay payments were prevented from redirecting to the success page due to an incorrect condition in the payment handler.
3 changes: 1 addition & 2 deletions packages/magento-payment-multisafepay/components/MSPPaymentHandler/MSPPaymentHandler.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,8 +18,7 @@ export function MSPPaymentHandler(props: PaymentHandlerProps) {

const { justLocked, success, cart_id: cartId, locked, method, order_number } = lockStatus

const canProceed =
!justLocked && locked && cartId && method === code && !called && success !== '1'
const canProceed = !justLocked && locked && cartId && method === code && !called

// When the payment has failed we restore the current cart
const shouldRestore = canProceed && success !== '1'
Expand Down
Loading