Skip to content

parseSync -> argv for async commands #260

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
benjie merged 2 commits into from
Sep 8, 2026
Merged

parseSync -> argv for async commands #260

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f2d8490
Cannot use parseSync
benjie Sep 8, 2026
16d5835
Add changeset
benjie Sep 8, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/easy-dolls-show.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
"graphile-migrate": patch
---

parseSync can't work with subcommands; revert to argv/isPromise
15 changes: 12 additions & 3 deletions src/cli.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,6 @@
#!/usr/bin/env node
import { isPromise } from "node:util/types";

import yargs from "yargs";

import { commitCommand } from "./commands/commit";
Expand Down Expand Up @@ -37,7 +39,7 @@ function wrapHandler<T1, T2>(
};
}

yargs
const argv = yargs
.parserConfiguration({
"boolean-negation": true,
"camel-case-expansion": false,
Expand Down Expand Up @@ -101,5 +103,12 @@ You are running graphile-migrate v${version}.
║ 🙏 THANK YOU SPONSORS! 🙏 ║
╚═══════════════════════════════════╝
`,
)
.parseSync();
).argv;

if (isPromise(argv)) {
argv.then(null, (e) => {
// eslint-disable-next-line no-console
console.error(e);
process.exit(1);
});
}