Skip to content

GFQL: admit bounded ORDER/LIMIT MATCH reentry top-k (#1342)#1346

Merged
lmeyerov merged 2 commits into
masterfrom
chore-880-umbrella-triage-refresh
May 9, 2026
Merged

GFQL: admit bounded ORDER/LIMIT MATCH reentry top-k (#1342)#1346
lmeyerov merged 2 commits into
masterfrom
chore-880-umbrella-triage-refresh

Conversation

@lmeyerov
Copy link
Copy Markdown
Contributor

@lmeyerov lmeyerov commented May 7, 2026

Summary

  • relax bounded MATCH-reentry prefix ordering guard to admit WITH+ORDER BY+LIMIT literal for multi-row top-k prefixes
  • keep conservative guards for unbounded ORDER BY and parameterized LIMIT
  • add lowering regression coverage for ordered top-k reentry (single-column + multi-column) plus cuDF parity test
  • update CHANGELOG.md development section

Why
Issue #1342 (under #880 umbrella) tracks a benchmark-visible gap where ordered top-k prefixes were rejected before trailing MATCH re-entry, even though runtime reentry seeding already preserves prefix row order.

Validation

  • python -m pytest -q graphistry/tests/compute/gfql/cypher/test_lowering.py -k with_match_reentry_limit_shape or ordered_topk_multi_row_shape or ordered_topk_multicolumn_shape or rejects_reentry_with_parameterized_limit_and_order or failfast_rejects_with_match_reentry_unsupported_shapes
  • python -m pytest -q graphistry/tests/compute/gfql/cypher/test_lowering.py -k with_match_reentry and (order or limit)
  • uv run ruff check graphistry/compute/gfql/cypher/reentry/carry.py graphistry/tests/compute/gfql/cypher/test_lowering.py

Issue links

@lmeyerov lmeyerov force-pushed the chore-880-umbrella-triage-refresh branch from b043334 to 6e607c9 Compare May 8, 2026 21:01
@lmeyerov lmeyerov merged commit e35d289 into master May 9, 2026
137 checks passed
@lmeyerov lmeyerov deleted the chore-880-umbrella-triage-refresh branch May 9, 2026 00:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant