Skip to content

GFQL/Cypher: bounded reentry ORDER BY admits parameterized LIMIT (#1349)#1352

Merged
lmeyerov merged 1 commit into
masterfrom
issue-1349-vectorized-row-pipeline
May 9, 2026
Merged

GFQL/Cypher: bounded reentry ORDER BY admits parameterized LIMIT (#1349)#1352
lmeyerov merged 1 commit into
masterfrom
issue-1349-vectorized-row-pipeline

Conversation

@lmeyerov
Copy link
Copy Markdown
Contributor

@lmeyerov lmeyerov commented May 8, 2026

Summary

  • resolve bounded reentry LIMIT values from runtime params when LIMIT $n is used in MATCH ... WITH ... ORDER BY ... LIMIT ... MATCH ... shapes
  • treat resolved non-negative integer limits as bounded-safe for prefix ORDER BY reentry checks (still requires no prefix SKIP when trailing ORDER BY is absent)
  • keep fail-fast behavior for unresolved/non-integer limits
  • add focused pandas + cuDF regressions for parameterized LIMIT, and keep shared-GPU environments stable by using _require_cudf_runtime() in reentry cuDF tests

Issue

Part of #1349

Validation

  • python -m pytest -q graphistry/tests/compute/gfql/cypher/test_lowering.py -k "parameterized_limit_shape or parameterized_non_int_limit_and_order or with_match_reentry_limit_shape"
  • ./bin/ruff.sh graphistry/compute/gfql/cypher/reentry/carry.py graphistry/compute/gfql/cypher/reentry/compiletime.py graphistry/tests/compute/gfql/cypher/test_lowering.py
  • ./bin/mypy.sh graphistry/compute/gfql/cypher/reentry/carry.py graphistry/compute/gfql/cypher/reentry/compiletime.py
  • ssh dgx-spark (RAPIDS_VERSION=26.02, targeted cuDF tests): 1 passed, 1 skipped (shared GPU memory pressure)
  • ssh dgx-spark (RAPIDS_VERSION=25.02, targeted cuDF parameterized-limit test): 1 passed

@lmeyerov lmeyerov force-pushed the issue-1349-vectorized-row-pipeline branch 2 times, most recently from ff973af to c45941b Compare May 8, 2026 21:03
@lmeyerov lmeyerov force-pushed the issue-1349-vectorized-row-pipeline branch from c45941b to d71161c Compare May 9, 2026 00:10
@lmeyerov lmeyerov marked this pull request as ready for review May 9, 2026 00:33
@lmeyerov lmeyerov merged commit 5f1c1a7 into master May 9, 2026
137 checks passed
@lmeyerov lmeyerov deleted the issue-1349-vectorized-row-pipeline branch May 9, 2026 00:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant