Skip to content

[codex] Add #1416 recursive ancestor row-join regression#1423

Merged
lmeyerov merged 1 commit into
masterfrom
codex/issue-1416-recursive-ancestor-row-join
May 11, 2026
Merged

[codex] Add #1416 recursive ancestor row-join regression#1423
lmeyerov merged 1 commit into
masterfrom
codex/issue-1416-recursive-ancestor-row-join

Conversation

@lmeyerov
Copy link
Copy Markdown
Contributor

@lmeyerov lmeyerov commented May 10, 2026

Summary

Adds focused regression coverage for #1416 / #880 around the GFQL recursive ancestor row-join lane.

The existing IS6-style test covered a Comment input where REPLY_OF*0.. reaches the Post ancestor through nonzero hops. This adds the matching Post input case, where the post ancestor must bind through the zero-hop arm before joining to forum/moderator rows.

Investigation

  • The referenced rerun artifact results/runs/local-snb-interactive-closeout-2026-05-09 is not present in this checkout.
  • In-repo residual triage only reads probe-results.json; the suite runner/adapter fallback producer is not present here.
  • Current direct GFQL execution passes the nonzero-hop and zero-hop row-binding cases locally.

Validation

  • python3 -m pytest -q graphistry/tests/test_compute_chain.py::TestChainBindingsTable::test_direct_rows_binding_ops_supports_open_range_multihop_continuation graphistry/tests/test_compute_chain.py::TestChainBindingsTable::test_direct_rows_binding_ops_supports_zero_hop_post_ancestor_join graphistry/tests/test_compute_chain.py::TestChainBindingsTable::test_direct_rows_binding_ops_supports_bounded_open_range_multihop_continuation
  • ./bin/lint.sh graphistry/tests/test_compute_chain.py

Local blockers

  • Full TestChainBindingsTable is not clean in this local environment: cuDF tests fail because no CUDA device is available, and row-expression tests fail because the parser backend dependency is missing.

Refs #1416. Fresh benchmark rerun confirmation is still required before closing the issue.

@lmeyerov lmeyerov marked this pull request as ready for review May 11, 2026 00:21
@lmeyerov lmeyerov merged commit fdd0f84 into master May 11, 2026
137 checks passed
@lmeyerov lmeyerov deleted the codex/issue-1416-recursive-ancestor-row-join branch May 11, 2026 00:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant