[codex] Add #1416 recursive ancestor row-join regression#1423
Merged
Conversation
This was referenced May 11, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds focused regression coverage for #1416 / #880 around the GFQL recursive ancestor row-join lane.
The existing IS6-style test covered a
Commentinput whereREPLY_OF*0..reaches thePostancestor through nonzero hops. This adds the matchingPostinput case, where the post ancestor must bind through the zero-hop arm before joining to forum/moderator rows.Investigation
results/runs/local-snb-interactive-closeout-2026-05-09is not present in this checkout.probe-results.json; the suite runner/adapter fallback producer is not present here.Validation
python3 -m pytest -q graphistry/tests/test_compute_chain.py::TestChainBindingsTable::test_direct_rows_binding_ops_supports_open_range_multihop_continuation graphistry/tests/test_compute_chain.py::TestChainBindingsTable::test_direct_rows_binding_ops_supports_zero_hop_post_ancestor_join graphistry/tests/test_compute_chain.py::TestChainBindingsTable::test_direct_rows_binding_ops_supports_bounded_open_range_multihop_continuation./bin/lint.sh graphistry/tests/test_compute_chain.pyLocal blockers
TestChainBindingsTableis not clean in this local environment: cuDF tests fail because no CUDA device is available, and row-expression tests fail because the parser backend dependency is missing.Refs #1416. Fresh benchmark rerun confirmation is still required before closing the issue.