[GFQL] Lock reply-author row-shaping coverage#1425
Merged
Conversation
This was referenced May 11, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
rows()regression coverage for the [POST-RERUN] #880 residual: reply-author row-shaping bucket #1412 SNB reply-author row-shaping residual bucket.recent-repliesand IS7message-replies.rows()injection and explicitrows(binding_ops=...), locking the pygraphistry-side behavior needed to retire adapter-local reply-author joins inpyg-bench.Refs #1412
Validation
python3 -m pytest -q graphistry/tests/test_compute_chain.py -k 'issue_1412'python3 -m pytest -q graphistry/tests/test_compute_chain.py -k 'issue_1412 or native_chain_rows_bindings_with_select'./bin/ruff.sh graphistry/tests/test_compute_chain.pygit diff --checkNotes
TestChainBindingsTablelocal run is blocked by environment gaps unrelated to this patch: no CUDA device for cuDF tests and missinglarkfor row-expression parser tests.pyg-benchstill needs the adapter workaround removal and fresh rerun before [POST-RERUN] #880 residual: reply-author row-shaping bucket #1412 can be fully closed.