Skip to content

Fix #1413 IC3 carried-row reentry#1428

Open
lmeyerov wants to merge 2 commits into
masterfrom
issue-1413-ic3-carried-row-reentry
Open

Fix #1413 IC3 carried-row reentry#1428
lmeyerov wants to merge 2 commits into
masterfrom
issue-1413-ic3-carried-row-reentry

Conversation

@lmeyerov
Copy link
Copy Markdown
Contributor

@lmeyerov lmeyerov commented May 11, 2026

Summary

  • Fixes [POST-RERUN] #880 residual: joined row aggregation bucket #1413 IC3/cross-country carried-row reentry shape: WITH person, collect(city) AS cities MATCH ...
  • Admits multiple post-reentry WITH stages for the single-reentry IC3 suffix
  • Carries collected node-entity lists through whole-row reentry and evaluates NOT friendCity IN cities
  • Keeps direct optional-match RETURN n, collect(x) in the validation-failure bucket until optional null filtering is supported
  • Adds adversarial regressions for collect(city), collect(DISTINCT city), CASE aggregation, post-aggregate filtering, TCK optional aggregate boundary, and cuDF reentry smoke

Validation

  • PYTHONPATH=/tmp/pygraphistry-issue-1413-deps python3 -m pytest -q graphistry/tests/compute/gfql/cypher/test_lowering.py -k 'issue_1413_ic3 or optional_match_collect_null_whole_row_return_boundary or optional_match_collect_alias_property or optional_match_collect_case_relationship_rows or failfast_relationship_whole_row_grouped_count_star_boundary' -> 6 passed
  • PYTHONPATH=/tmp/pygraphistry-issue-1413-deps python3 -m pytest -q graphistry/tests/compute/gfql/cypher/test_lowering.py -k '(issue_1413 or multi_alias_with_distinct_scalar_projection or graph_backed_unwind_after_with or post_with_match_collect_unwind_match or multi_stage_with_match_reentry or aggregate_whole_row or collect_alias_property or optional_match_collect_null_whole_row_return_boundary) and not cudf' -> 23 passed
  • PYTHONPATH=/tmp/pygraphistry-issue-1413-deps python3 -m pytest -q graphistry/tests/compute/gfql/cypher/test_lowering.py -k 'not cudf' -> 896 passed, 12 skipped
  • PYTHONPATH=/home/lmeyerov/Work/pygraphistry2:/tmp/tck-gfql-f02d17c:/tmp/pygraphistry-issue-1413-deps python3 -m pytest -q tests/cypher_tck/test_tck_runner.py::test_direct_cypher_xfail_contract --tb=short -> 783 passed
  • python3 -m ruff check ... -> passed
  • PYTHONPATH=/tmp/pygraphistry-issue-1413-deps python3 -m py_compile ... -> passed
  • PYTHONPATH=/tmp/pygraphistry-issue-1413-deps python3 bin/ci_cypher_surface_guard.py -> passed
  • git diff --check -> passed
  • DGX Spark RAPIDS matrix: MATRIX_CELLS="25.02:gfql 26.02:gfql" WITH_IMAGE_BUILD=0 WITH_GPU=1 WITH_LINT=0 WITH_TYPECHECK=0 WITH_TEST=1 PROFILE=gfql TEST_FILES="..." ./test-rapids-official-matrix.sh -> 25.02/gfql PASS, 26.02/gfql PASS
  • GitHub PR checks on f111dac4 -> green, including duplicated tck-gfql

Notes

  • Surface guard baseline line-count update is intentional for this compiler slice; dataclass/API surface counts are unchanged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[POST-RERUN] #880 residual: joined row aggregation bucket

1 participant