Validate non-file manifest fields with file data sources#2141
Open
DeepCogNeural wants to merge 2 commits into
Open
Validate non-file manifest fields with file data sources#2141DeepCogNeural wants to merge 2 commits into
DeepCogNeural wants to merge 2 commits into
Conversation
🦋 Changeset detectedLatest commit: f231e1c The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #2045
Summary
file/ipfstemplate no longer hides a numericnetworkvalue in a regular Ethereum data sourceTests
npx pnpm@9.15.9 --filter @graphprotocol/graph-cli exec vitest run tests/cli/validation.test.ts -t "File data source does not skip regular manifest validation" -unpx pnpm@9.15.9 --filter @graphprotocol/graph-cli test:validationnpx pnpm@9.15.9 --filter @graphprotocol/graph-cli build../../packages/cli/bin/run.js codegen --skip-migrationsinexamples/matic-lens-protocol-posts-subgraphnpx pnpm@9.15.9 exec prettier --check packages/cli/src/subgraph.ts packages/cli/tests/cli/validation.test.ts packages/cli/tests/cli/validation/file-data-source-invalid-manifest/subgraph.yaml packages/cli/tests/cli/validation/file-data-source-invalid-manifest/schema.graphql packages/cli/tests/cli/validation/file-data-source-invalid-manifest/Abi.jsongit diff --checkNote:
npx pnpm@9.15.9 --filter @graphprotocol/graph-cli type-checkcurrently fails on existing generated imports undertests/cli/add/subgraph/src/mapping.ts; this PR does not touch that fixture.