Allow custom endpoint URL.

[kivutar]

Attempt to address #31
Websocket subscriptions are now working.

[coveralls]

Coverage increased (+0.2%) to 87.5% when pulling 593f69e on Kivutar:master into cc93f95 on graphql-go:master.

[coveralls]

Coverage decreased (-1.4%) to 85.876% when pulling 69f77bc on Kivutar:master into cc93f95 on graphql-go:master.

[coveralls]

Coverage decreased (-1.4%) to 85.876% when pulling 69f77bc on Kivutar:master into cc93f95 on graphql-go:master.

[Jannis]

I'd recommend separating the GraphiQL configuration parameters from the handler configuration a bit. Apart from that this looks great!

[Jannis]

Instead of making EndpointURL and SubscriptionsEndpoint top-level configuration fields, it would probably be cleaner to group them under a GraphiQLConfig field that can optionally be passed in together with GraphiQL: true. Example:

handler.New(&handler.Config{
    Schema: ...,
    GraphiQL: true,
    GraphiQLConfig: &handler.GraphiQLConfig{
        Endpoint: ...,
        SubscriptionsEndpoint: ...,
    }
})

[Jannis]

I noticed that the Apollo server code for GraphiQL mentioned in #31 has a few more configuration variables that might make sense to add here (like additional HTTP headers to be passed to the endpoint for e.g. authentication).

[Jannis]

Only EndpointURLWS is being used in the template, SubscriptionsEndpoint isn't. I personally favor the name SubscriptionsEndpoint and would pass Endpoint and SubscriptionsEndpoint (falling back to Endpoint if not set) in to the template.

[coveralls]

Coverage decreased (-1.5%) to 85.795% when pulling aace1d0 on Kivutar:master into cc93f95 on graphql-go:master.

[coveralls]

Coverage decreased (-1.5%) to 85.795% when pulling aace1d0 on Kivutar:master into cc93f95 on graphql-go:master.

[kivutar]

Thanks for your reviews.

If I use a pointer for GraphiQLConfig I have to handle too many pointer dereferences in order to access the values. (I'm a golang beginner)

And if I use a plain struct, my changes are not consistent anymore with the current code, as handler.Config is a pointer.

What should I do?

[coveralls]

Coverage decreased (-1.5%) to 85.795% when pulling d34f105 on Kivutar:master into cc93f95 on graphql-go:master.

[coveralls]

Coverage decreased (-1.5%) to 85.795% when pulling 9041423 on Kivutar:master into cc93f95 on graphql-go:master.

[ccamel]

@kivutar What's the status on this one ? I'd be really interested in having this feature available. 😄