Open
Conversation
Author
|
@chris-ramon Nudge - would it be possible to have this looked at? |
|
hi all, When will it merge to master ? |
Author
|
@chris-ramon Any chance that this could get a review, will clean up the conflict shortly. |
|
@koblas conflicts |
Author
|
@appleboy Conflicts resolved... Hopefully, someday @chris-ramon will feel like merging. |
|
Can we merge this? |
|
While waiting this being merged, found an alternative handler supporting Originally posted at graphql-go/graphql#607 Just provide one more option 😃 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR should support Multipart form-data file upload requests as specified by https://github.com/jaydenseric/graphql-multipart-request-spec -- which is adopted by the Apollo team. It also works without file uploads as a general handler.