Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request updates the access token deletion confirmation dialog text to clarify that deletion is permanent. It is recommended to also mention the 5-minute propagation delay for the invalidation to set accurate user expectations.
...components/organization/settings/access-tokens/delete-access-token-confirmation-dialogue.tsx
Outdated
Show resolved
Hide resolved
Contributor
|
🐋 This PR was built and pushed to the following Docker images: Targets: Platforms: Image Tag: |
jonathanawesome
approved these changes
Mar 26, 2026
jdolle
commented
Mar 26, 2026
| toast({ | ||
| variant: 'default', | ||
| title: 'Access Token deleted.', | ||
| description: 'It can take up to 5 minutes for changes to propagate.', |
Collaborator
Author
There was a problem hiding this comment.
this text is redundant from the confirmation now and only creates more visual noise when users want to just know that the action has occurred.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Background
While reviewing documentation and updating screenshots, I noticed our text doesn't make much sense when deleting a token.
Description
This clarifies what will happen when the token is deleted.