Skip to content

Use the session in async subs example#585

Merged
leszekhanusz merged 1 commit into
graphql-python:masterfrom
jaylett:patch-1
Feb 23, 2026
Merged

Use the session in async subs example#585
leszekhanusz merged 1 commit into
graphql-python:masterfrom
jaylett:patch-1

Conversation

@jaylett

@jaylett jaylett commented Feb 23, 2026

Copy link
Copy Markdown
Contributor

client.subscribe() is not async safe, but session.subscribe() is.

client.subscribe() is not async safe, which is the point of constructing the session instead.
@leszekhanusz

Copy link
Copy Markdown
Collaborator

Thank you!

@leszekhanusz leszekhanusz added the type: documentation An issue or pull request for improving or updating the documentation label Feb 23, 2026
@leszekhanusz leszekhanusz merged commit b57afa6 into graphql-python:master Feb 23, 2026
14 checks passed
@codecov

codecov Bot commented Feb 23, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 100.00%. Comparing base (7fb869a) to head (e054045).
⚠️ Report is 51 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##            master      #585    +/-   ##
==========================================
  Coverage   100.00%   100.00%            
==========================================
  Files           38        40     +2     
  Lines         2908      3311   +403     
==========================================
+ Hits          2908      3311   +403     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@jaylett jaylett deleted the patch-1 branch February 24, 2026 16:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

type: documentation An issue or pull request for improving or updating the documentation

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants