polish(validateInputValue): cover invalid values in iterable input - #4845
Open
vrana055 wants to merge 1 commit into
Open
polish(validateInputValue): cover invalid values in iterable input#4845vrana055 wants to merge 1 commit into
vrana055 wants to merge 1 commit into
Conversation
The list test for non-array iterables only asserted the success case and carried a TODO asking for an error case. Add one so the reported error paths for a generator input are pinned down.
|
@vrana055 is attempting to deploy a commit to the The GraphQL Foundation Team on Vercel. A member of the Team first needs to authorize it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
validateInputValueaccepts any iterable for a list type, but the iterable test only asserted the success case and carried aTODO: put an error in this list and show it appears.This adds the error case: a generator yielding an invalid item, asserting the reported error paths use the item indices. The TODO comment is removed.
No behaviour change — tests only.