feat: add RangeInputPicker component with number input and view support#360
Merged
Conversation
Contributor
|
Preview is ready. |
Contributor
|
Playwright Test Component is ready. |
bocembocem
requested changes
May 25, 2026
| multi_oneof_flat: {Component: MultiOneOfFlatView, independent: true}, | ||
| inline: {Component: ObjectInlineView, independent: true}, | ||
| time_range_selector: {Component: TimeRangeSelectorView, independent: true}, | ||
| range_input_picker: {Component: RangeInputPickerView, independent: true}, |
Collaborator
There was a problem hiding this comment.
Same thing about this flag
| multi_oneof_flat: {Component: MultiOneOfFlat, independent: true}, | ||
| inline: {Component: ObjectInline, independent: true}, | ||
| time_range_selector: {Component: TimeRangeSelector, independent: true}, | ||
| range_input_picker: {Component: RangeInputPicker, independent: true}, |
Collaborator
There was a problem hiding this comment.
It looks like the independent flag isn’t needed here. If you’re not implementing any special logic or hardcoding the Layout in the code, and if the main purpose of this flag is this code https://github.com/gravity-ui/dynamic-forms/pull/360/changes#diff-776662bd58caae175544f2b0a894fb52bd511afecfe1da02fbf4ccdfcbb5c6afR183, then it will happen automatically in the Controller. You can remove both this code and the independent flag.
| } | ||
|
|
||
| return fallback; | ||
| }; |
Collaborator
There was a problem hiding this comment.
Feels like I’ve seen this somewhere before 👀
DEFAULT_MIN, DEFAULT_MAX -> constants
clamp, resolveBound -> utils
…s to constants and utils
bocembocem
approved these changes
May 25, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.