Merged
Conversation
resure
reviewed
Apr 2, 2026
|
|
||
| const expressClientIpHeaderName = ctx.config.expressClientIpHeaderName?.toLowerCase(); | ||
| if (expressClientIpHeaderName) { | ||
| const clientIp = req.headers[expressClientIpHeaderName] as string | undefined; |
Contributor
There was a problem hiding this comment.
- Should probably add a few tests for this
- Wouldn't it be overridden by standard logic that fills req.ip based on the content of x-forwarded-for?
Contributor
Author
There was a problem hiding this comment.
Wouldn't it be overridden by standard logic that fills req.ip based on the content of x-forwarded-for?
express uses getter, we redefine it
I checked it works
https://github.com/expressjs/express/blob/e5099198b292a565f8583d70caf12d7afed3607f/lib/request.js#L340
I'll add some tests
DakEnviy
reviewed
Apr 2, 2026
stepanenkoxx
commented
Apr 2, 2026
src/tests/client-ip-header.test.ts
Outdated
Comment on lines
+101
to
+118
| it('should handle multiple IPs in X-Forwarded-For header', async () => { | ||
| const customIpHeader = 'X-Forwarded-For'; | ||
| const multipleIps = '203.0.113.1, 198.51.100.2, 192.0.2.3'; | ||
|
|
||
| const {app} = setupApp({ | ||
| config: { | ||
| expressClientIpHeaderName: customIpHeader, | ||
| }, | ||
| }); | ||
|
|
||
| const agent = request.agent(app.express); | ||
|
|
||
| const response = await agent.get('/ip').set(customIpHeader, multipleIps); | ||
|
|
||
| expect(response.status).toBe(200); | ||
| expect(response.body.ip).toBe(multipleIps); | ||
| }); | ||
| }); |
Contributor
Author
There was a problem hiding this comment.
don't know maybe in this case we need to split value and take 0 element
or maybe instead of header name we could pass a getter function
Contributor
Author
There was a problem hiding this comment.
it's clientIpHeader, so i think we must pass it as is actually
i'll remove this test case
resure
approved these changes
Apr 7, 2026
DakEnviy
approved these changes
Apr 7, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.