Conversation
Contributor
|
Preview is ready. |
draedful
force-pushed
the
collapse_group
branch
3 times, most recently
from
7063130 to
0244f06
Compare
draedful
force-pushed
the
collapse_group
branch
from
9aa9179 to
39cefbd
Compare
draedful
commented
Apr 6, 2026
| }; | ||
| ``` | ||
|
|
||
| - **`key`** (required) — unique identifier for the area within the component. If an area with the same key already exists, it is replaced instead of duplicated. Also used to persist the area's local state across render cycles. |
Collaborator
Author
There was a problem hiding this comment.
Less details please
draedful
commented
Apr 6, 2026
| blockPort.isDelegated; // false | ||
| ``` | ||
|
|
||
| #### How CollapsibleGroup uses delegation |
draedful
commented
Apr 6, 2026
| if (canvasVisible !== undefined) { | ||
| viewState?.setHiddenBlock(Boolean(canvasVisible)); | ||
| // Manual control: delegate canvas rendering when canvasVisible=false | ||
| viewState?.setRenderDelegated(!canvasVisible); |
Collaborator
Author
There was a problem hiding this comment.
check is this real needs, because Block will remove self hitbox
Antamansid
approved these changes
Apr 7, 2026
| width: rect.width + GROUP_PAD * 2, | ||
| height: rect.height + GROUP_PAD * 2, | ||
| }, | ||
| collapsed: !!(Math.floor(Math.random() * 10) % 2), |
Collaborator
There was a problem hiding this comment.
It's unnecessary here. Now, if you work with a story there are groups that open/close at random because of this line, even if you don't touch them
| const sourcePort = this.$sourcePortState.value; | ||
| const targetPort = this.$targetPortState.value; | ||
| if (!sourcePort.lookup && !targetPort.lookup) { | ||
| return [sourcePort.$point.value, targetPort.$point.value]; |
Collaborator
There was a problem hiding this comment.
As I understand this is breaking change, but hardly anyone signed up for this at all.
| * (React overlay mode, hitbox kept). Both flags make isVisible() return false, | ||
| * but only blockHidden removes the hitbox. | ||
| */ | ||
| private blockHidden = false; |
Collaborator
There was a problem hiding this comment.
Can we put it in the state? I see that this has already been done in the connections, but here we have to store data both in the staff and here, and even synchronize them.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.