Display frequency in kHz on PortaPack#1756
Open
martinling wants to merge 2 commits into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Following recent internal changes, the frequency display on the built-in PortaPack UI has been displaying RF frequencies slightly different from those requested by host software.
This is correct, in that the displayed frequency reflected the best-match RF frequency achieved by the tuning code, but is confusing for the end user, due to the unexpected and unexplained discrepancy.
To avoid confusion, this PR changes the units of the PortaPack frequency display to kHz, adds the
kHztext to the display, and rounds the achieved RF frequency to kHz precision. This brings the behaviour in line with that on rad1o as of #1744.In practice, the tuning error will be smaller than the local oscillator error even with a 0.5ppm TCXO, so the differences reported at Hz precision were normally meaningless in practice. Users needing the error information can still fetch it from the device, at greater precision than was available from the display.